Skip to content

[codex] Clean up service details overview UI#106

Merged
arjunkomath merged 2 commits into
mainfrom
feat-service-details-ui-cleanup
Jul 7, 2026
Merged

[codex] Clean up service details overview UI#106
arjunkomath merged 2 commits into
mainfrom
feat-service-details-ui-cleanup

Conversation

@techulus-agent

Copy link
Copy Markdown
Collaborator

Summary

  • Remove the redundant public/private endpoint count chip from the service details overview.
  • Remove the Capacity and Data & ops summary sections.
  • Move resource limits into the Instances section.
  • Default the request graph to Total instead of RPS.

Validation

  • pnpm exec biome check components/service/details/service-details-overview.tsx
  • pnpm exec tsc --noEmit

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

React Doctor found no new issues. 🎉

Reviewed by React Doctor for commit ac63efc.

@arjunkomath arjunkomath marked this pull request as ready for review July 7, 2026 07:21

@techulus-agent techulus-agent left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review — Clean up service details overview UI

Reviewed the diff against main. This is a focused, low-risk UI cleanup and it holds together well.

Verified

  • All eight removed helpers (getLockedServerLabel, formatReplicaCompact, formatPlacementLabel, formatEndpointCount, formatDataSummary, formatBackupLabel, formatDeployScheduleLabel, lowercaseFirstLetter) and the now-unused imports (cronstrue, Cpu, HardDrive) have zero remaining references in the file — no orphaned calls or dead imports left behind.
  • Helpers that were shared with the removed sections (formatInstanceSummary, getConfiguredReplicaCount, formatResources, formatPortSummary, formatCount) are all still defined and still used.
  • Moving resource limits into the Instances section and dropping the Capacity / Data & ops cards is coherent; the request-graph default flipping to Total matches the reordered toggle (Total first, then RPS).
  • The border-border / ring-0 class additions are purely cosmetic.

Result: No correctness or dead-code issues. LGTM 👍

@arjunkomath arjunkomath merged commit 2393233 into main Jul 7, 2026
9 checks passed
@arjunkomath arjunkomath deleted the feat-service-details-ui-cleanup branch July 7, 2026 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants